sir-lancebot icon indicating copy to clipboard operation
sir-lancebot copied to clipboard
Published 1 month ago • verified publisher icon python-discord

Update uptime command to use a relative timestamp

Open rtk-rnjn opened this issue 4 years ago • 9 comments

Description

Uptime command https://github.com/python-discord/sir-lancebot/blob/main/bot/exts/core/ping.py#L29-L40

Reasoning

It look cool

Proposed Implementation

Use Relative timestamp of discord <t:TIMESTAMP:R>

Would you like to implement this yourself?

  • [ ] I'd like to implement this feature myself
  • [x] Anyone can implement this feature

rtk-rnjn avatar Jan 22 '22 04:01 rtk-rnjn

can i be assigned?

MaskDuck avatar Feb 20 '22 10:02 MaskDuck

can i be assigned?

This hasn't been approved yet, but if/when it does then I don't see an issue with that.

TizzySaurus avatar Feb 20 '22 11:02 TizzySaurus

This command already exists.

Akarys42 avatar Feb 20 '22 11:02 Akarys42

This command already exists.

I think they're suggesting that the command be updated to use relative timestamps instead of manually getting humanized time.

TizzySaurus avatar Feb 20 '22 12:02 TizzySaurus

Right, now I understand 😅

Akarys42 avatar Feb 20 '22 12:02 Akarys42

can i be assigned

MaskDuck avatar Feb 22 '22 07:02 MaskDuck

Timestamps do rounding, which isn't something I want if I need to check for uptime. Relative timestamps also don't work on mobile.

mbaruh avatar Mar 15 '22 09:03 mbaruh

I agree with @mbaruh, the rounding on relative timestamps makes them annoying for things like this

vcokltfre avatar Mar 15 '22 09:03 vcokltfre

didnt know =(

MaskDuck avatar Mar 15 '22 10:03 MaskDuck