bot icon indicating copy to clipboard operation
bot copied to clipboard

Reply to !eval message instead of pinging

Open Robin5605 opened this issue 3 years ago • 6 comments

It was discussed in #community-meta if the !eval command should reply to the original command instead of sending a separate message with a ping. Thoughts on this? I'd be willing to PR if accepted.

Robin5605 avatar Jan 15 '23 05:01 Robin5605

Sounds good to me, I don't see why not.

wookie184 avatar Jan 15 '23 10:01 wookie184

What would happen when the command is invoked in a non-whitelisted channel? I suppose it'd have to still send a new message that pings in bot-commands?

Also would the reply be ephemeral? We presumably don't want that, since a lot of the time the eval command is used to showcase something, meaning other people need to see the outcome.

And I believe @bj0key, the user who raised this, said they'd like to implement this fwiw @Robin5605

TizzySaurus avatar Jan 15 '23 11:01 TizzySaurus

Yeah this seems good. Sometimes the eval takes a while and returns a few messages after the original !eval, so it's unclear which eval resulted in the output, the reply would provide a clickable link.

ionite34 avatar Jan 15 '23 12:01 ionite34

Yeah, I wouldn't mind implementing this. I think it'd also be worth having !timeit also reply on response, for the sake of parity between the two evaluation-based commands.

bj0key avatar Jan 15 '23 14:01 bj0key

I can take on this!

e1pupper avatar Feb 13 '23 17:02 e1pupper

Sorry for not noticing your message earlier @bj0key, I assigned it to someone else, hope you don't mind.

mbaruh avatar Feb 14 '23 00:02 mbaruh