bot icon indicating copy to clipboard operation
bot copied to clipboard
verified publisher icon python-discord

seperate tag dataclasses from tag cog file

Open onerandomusername opened this issue 4 years ago • 3 comments

Relevant Issues

closes #2022

Description

Move the dataclasses that are used by the source cog out of the tag cog file in order to fix the current import issue.

See https://github.com/python-discord/bot/issues/2022#issuecomment-997541569 for a longer explanation.

onerandomusername avatar Jan 12 '22 11:01 onerandomusername

If going with this approach, I think it would make more sense to make the tags extension a package with a separate module for the cog and the non-cog classes instead of moving the classes to utils

Numerlor avatar Jan 12 '22 15:01 Numerlor

If going with this approach, I think it would make more sense to make the tags extension a package with a separate module for the cog and the non-cog classes instead of moving the classes to utils

Resolved as of https://github.com/python-discord/bot/pull/2046/commits/95de0f353012ae17dbfc7eea6fa71c18db93ac07

onerandomusername avatar Jan 15 '22 01:01 onerandomusername

Hello!

I'm curios if there are any plans of continuing to work on this again?

Nipa-Dev avatar Jun 03 '22 08:06 Nipa-Dev

I'm going to close this PR as:

  • From bluenix's comment it seems this approach doesn't fix the issue (and I don't think this refactor is worth doing otherwise)
  • There are quite a few conflicts
  • It's gone a long time without any activity

wookie184 avatar Sep 18 '22 17:09 wookie184