desert icon indicating copy to clipboard operation
desert copied to clipboard

Isra/optional default

Open isra17 opened this issue 2 years ago • 2 comments

I was investigating why Optional default was broken (ie. x: Optional[int] = 1 would default to None) and ended up refactoring a good bunch of the code, finding out that defaults seemed to be overall quite broken.

isra17 avatar Apr 27 '23 15:04 isra17

Codecov Report

Merging #269 (3e9b593) into main (0c43ff5) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #269   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          472       476    +4     
  Branches        90        93    +3     
=========================================
+ Hits           472       476    +4     
Impacted Files Coverage Δ
src/desert/_make.py 100.00% <100.00%> (ø)
tests/test_make.py 100.00% <100.00%> (ø)

codecov[bot] avatar Apr 27 '23 16:04 codecov[bot]

FYI I don't personally have time to work on this repo these days. Other collaborators should be able to review if they're interested, so you might ping someone to see if there's interest.

desert-bot avatar Apr 27 '23 17:04 desert-bot