Fix deprecation warnings
I was getting a few warning due to default and missing being removed in Marshmallow4.
Codecov Report
Merging #161 (96915dc) into main (6c5c54e) will not change coverage. The diff coverage is
100.00%.
@@ Coverage Diff @@
## main #161 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 472 472
Branches 76 76
=========================================
Hits 472 472
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/desert/_make.py | 100.00% <100.00%> (ø) |
|
| tests/cases/forward_reference.py | 100.00% <100.00%> (ø) |
|
| tests/test_make.py | 100.00% <100.00%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
If this could be merged over that would be amazing. I am getting the same deprecation warnings
Would love to see this get merged and released. It fixes https://github.com/python-desert/desert/issues/179.
It says the branch is out of date. If someone wants to rebase, I think we can merge.
Rebased!
Some test failures there, if anybody wants to work on them.
The issue is with marshmallow and was fixed in 3.15. I see dev-requirements.txt and test-requirements.txt pinned to 3.13 so likely the pin should just be updated.
I updated the dependencies in requirements.txt (running pip-compile --upgrade ...)
Seems like many dependencies are not supporting python 3.6 anymore (Such as marshmallow 3.15...)
Any thought about dropping python 3.6 support?
Seems like there's more error about typing in test_make and the setup of fixture generator I'm not familiar with. I've spent more time than I care at that point. Anyone feel free to take over!
Actually, I might have something that goes green now.
Ok this is it. I had to run the lock command under linux...
Ha, was just pointing that out. Nice work @isra17!
https://github.com/python-desert/desert/blob/6c5c54e81094b8c3f6bd488c1797e3b237e5229d/setup.py#L79 will need to be removed
done
We still need a changelog file:
Add a file in changelog.d/ describing the changes. The filename should be {id}.{type}.rst, where {id} is the number of the GitHub issue or pull request and {type} is one of breaking (for breaking changes), deprecation (for deprecations), or change (for non-breaking changes). For example, to add a new feature requested in GitHub issue #1234, add a file called changelog.d/1234.change.rst describing the change.
Sorry for the incremental revelations here, it's been a while and I don't remember the process all that well.
done!