babel icon indicating copy to clipboard operation
babel copied to clipboard

Fix: Unexpected behaviour: parse_numbers() doesn't handle space as a grouping symbol, however, parse_decimal() does #1061

Open sebas-inf opened this issue 2 years ago • 9 comments

Cleaned the string to ensure that it still works if there is a non-breakable space, \xa0, in the number and separed the logic so that it is easeir to understand.

sebas-inf avatar Jan 31 '24 01:01 sebas-inf

You've committed and pushed your entire .venv – please clean that up first.

Should I just push the file I changed or everything except the .venv?

sebas-inf avatar Jan 31 '24 08:01 sebas-inf

Should I just push the file I changed or everything except the .venv?

Your commit(s) should only have relevant changes.

akx avatar Jan 31 '24 08:01 akx

Should I just push the file I changed or everything except the .venv?

Your commit(s) should only have relevant changes.

Ok, I will push the file with the fix only then.

sebas-inf avatar Jan 31 '24 08:01 sebas-inf

You still have 755 files in this pull request. You'll probably need to git reset 40e60a1f6cf178d9f57fcc14f157ea1b2ab77361 (the current master), then carefully git add only the changes you want, git commit them, and git push --force-with-lease them to your repository.

akx avatar Jan 31 '24 18:01 akx

You still have 755 files in this pull request. You'll probably need to git reset 40e60a1f6cf178d9f57fcc14f157ea1b2ab77361 (the current master), then carefully git add only the changes you want, git commit them, and git push --force-with-lease them to your repository.

should i do all of this within the terminal in vscode where i was working?

sebas-inf avatar Jan 31 '24 18:01 sebas-inf

should i do all of this within the terminal in vscode where i was working?

Maybe. I don't use Visual Studio Code much. Visual Studio Code might have other tools for backing out commits.

akx avatar Jan 31 '24 18:01 akx

should i do all of this within the terminal in vscode where i was working?

Maybe. I don't use Visual Studio Code much. Visual Studio Code might have other tools for backing out commits.

It worked, I made it so i only pushed the numbers.py file.

sebas-inf avatar Jan 31 '24 19:01 sebas-inf

This will require rebasing, and there are still unresolved comments.

akx avatar Apr 24 '24 12:04 akx

@sebas-inf If you're still around, please see the comments and rebase this to resolve conflicts. Thanks :)

akx avatar Jul 11 '24 06:07 akx