adaptive icon indicating copy to clipboard operation
adaptive copied to clipboard

improve isosurface computation

Open jbweston opened this issue 6 years ago • 4 comments

When computing the isosurface, when 4 simplex edges crosses the isosurface, we add 2 triangles to the isosurface triangulation.

Right now we add these arbitrarily (in these 3 lines) but we should add them so that the curvature is minimized.

The current state of affairs produces plots like this:

K3D-1574269258138

Note how the isosurface on the right hand side of the figure is not smooth.

jbweston avatar Nov 20 '19 17:11 jbweston

Hey @jbweston can you put up the example notebook for producing the above plot somewhere?

oroszl avatar Nov 23 '19 20:11 oroszl

I had though about that before, but the four points which are found are co-planar, so it doesn't matter in what way you make the triangles. The roughness comes from differences between adjacent tetrahedra.

jhoofwijk avatar Jan 02 '20 11:01 jhoofwijk

@jhoofwijk thanks for the clarification, that's an excellent point.

akhmerov avatar Jan 02 '20 12:01 akhmerov

OTOH the isosurface seems to have artifacts... wondering how to investigate the specific origin of those...

akhmerov avatar Jan 06 '20 09:01 akhmerov