kanren icon indicating copy to clipboard operation
kanren copied to clipboard

Add Mypy typing

Open brandonwillard opened this issue 3 years ago • 2 comments

This project needs type annotations and a Mypy pre-commit hook.

brandonwillard avatar Jun 11 '22 13:06 brandonwillard

just throwing the idea here to just generate the types from running the tests.

(/mypy/ typing? or just typing?)

majidaldo avatar Jun 11 '22 14:06 majidaldo

just throwing the idea here to just generate the types from running the tests.

(/mypy/ typing? or just typing?)

This issue is for Mypy (i.e. checked typing), as well as the manual addition of type hints. This codebase is small enough for that to be done manually.

brandonwillard avatar Jun 11 '22 14:06 brandonwillard

can be closed (initially) with https://github.com/pythological/kanren/commit/7f9accbd7b31f7367bb5d0541397a3ce2dde4b8d#diff-789a9a451148e9f433bf6f9884fb3eb71cf80e3b44df048d464f081b53eb95a4

but the typing work could be more comprehensive.

majidaldo avatar Jan 30 '23 03:01 majidaldo