TopoModelX icon indicating copy to clipboard operation
TopoModelX copied to clipboard

ICML 2023: Initial commit of Simplicial Neural Networks

Open Hellsegga opened this issue 2 years ago • 5 comments

This is a minimal first pull request for an implementation of Stefania Ebli, Michael Defferrard and Gard Spreemann. Simplicial Neural Networks. TDA {&} Beyond. 2020.

Comparison with the code of the authors of that paper plus extension or addition of new examples in the tutorial will be done later.

Hellsegga avatar Jun 01 '23 18:06 Hellsegga

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

🚀 (The doc deployment issue is on us, it is not related to this PR.)

ninamiolane avatar Jun 01 '23 21:06 ninamiolane

Codecov Report

Merging #98 (5382ee0) into main (c471ea2) will increase coverage by 1.64%. The diff coverage is 100.00%.

:exclamation: Current head 5382ee0 differs from pull request most recent head edb885a. Consider uploading reports for the commit edb885a to get more accurate results

@@            Coverage Diff             @@
##             main      #98      +/-   ##
==========================================
+ Coverage   93.00%   94.64%   +1.64%     
==========================================
  Files           8        9       +1     
  Lines         200      224      +24     
==========================================
+ Hits          186      212      +26     
+ Misses         14       12       -2     
Impacted Files Coverage Δ
topomodelx/nn/simplicial/snn_layer.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

codecov[bot] avatar Jun 02 '23 15:06 codecov[bot]

Hello @Hellsegga ! Thank you for your submission. As we near the end of the challenge, I am collecting participant info for the purpose of selecting and announcing winners. Please email me (or have one member of your team email me) at [email protected] so I can share access to the voting form. In your email, please include:

  • your first and last name (as well as any other team members)
  • the title of the model you implemented
  • the domain of the model you implemented
  • your pull request number (#98)

Before July 13, make sure that your submission respects all Submission Requirements laid out on the challenge page. Any submission that fails to meet this criteria will be automatically disqualified.

mathildepapillon avatar Jul 03 '23 18:07 mathildepapillon

Note that the coauthorship dataset will not be loaded currently due to problem reported in https://github.com/pyt-team/TopoNetX/issues/195

A workaround is to install TopoNetX manually in editable mode git clone https://github.com/pyt-team/TopoNetX pip install -e '.[all]'

(instead of letting it be installed through the dependency management when installing TopoModelX).

This is also why "test_tutorial" fails.

Hellsegga avatar Jul 12 '23 13:07 Hellsegga