ani-cli icon indicating copy to clipboard operation
ani-cli copied to clipboard

feat: initial logger support

Open 71zenith opened this issue 1 year ago • 12 comments

Pull Request Template

Type of change

  • [ ] Bug fix
  • [ ] Feature
  • [ ] Documentation update

Description

ramble here

Checklist

  • [ ] any anime playing
  • [ ] bumped version

  • [ ] next, prev and replay work
  • [ ] -c history and continue work
  • [ ] -d downloads work
  • [ ] -s syncplay works
  • [ ] -q quality works
  • [ ] -v vlc works
  • [ ] -e select episode works
  • [ ] -S select index works
  • [ ] -r range selection works
  • [ ] --skip ani-skip works
  • [ ] --skip-title ani-skip title argument works
  • [ ] --no-detach no detach works
  • [ ] --dub and regular (sub) mode both work
  • [ ] all providers return links (not necessarily on a single anime, use debug mode to confirm)

  • [ ] -h help info is up to date
  • [ ] Readme is up to date
  • [ ] Man page is up to date

Additional Testcases

  • The safe bet: One Piece
  • Episode 0: Saenai Heroine no Sodatekata ♭
  • Unicode: Saenai Heroine no Sodatekata ♭
  • Non-whole episodes: Tensei shitara slime datta ken (ep. 24.5, ep. 24.9)

71zenith avatar Jun 14 '24 13:06 71zenith

@port19x it seems that journalctl cleans up the logs every few days? do u still wanna proceed with this feature

71zenith avatar Jun 21 '24 04:06 71zenith

:/

justchokingaround avatar Jun 21 '24 05:06 justchokingaround

@port19x it seems that journalctl cleans up the logs every few days? do u still wanna proceed with this feature

That's configured by the distro, on arch I still have logs from march. I'd say let's proceed

port19x avatar Jun 21 '24 06:06 port19x

i'd like someone to test this on mac @justchokingaround free?

71zenith avatar Jun 21 '24 06:06 71zenith

I have a m1 macbook air that I bought used like 2 weeks ago. I can do the testing if I remember

port19x avatar Jun 21 '24 07:06 port19x

@port19x did u test?

71zenith avatar Jun 25 '24 05:06 71zenith

I didn't forget to check, but I forgot this is already done, since it's still a draft PR. I was confused by your inactivity. Will test later today

port19x avatar Jun 25 '24 08:06 port19x

Not quite there yet. Ani-cli -l hangs Screenshot 2024-06-26 at 07 28 55

port19x avatar Jun 26 '24 05:06 port19x

can u check the docs to see how to print the logs. its hard for me to rely on stack overflow and random forums

71zenith avatar Jun 26 '24 05:06 71zenith

Yeah, but might not get to it today

port19x avatar Jun 26 '24 07:06 port19x

I had to take care of an elephant this weekend. I'll see that I get this done sometime this week.

the elephant in question

port19x avatar Jul 01 '24 08:07 port19x

I had to take care of an elephant this weekend. I'll see that I get this done sometime this week.

the elephant in question

Noice, well it's a great language, and it will be like a stain on ur life 🙃

CoolnsX avatar Jul 01 '24 09:07 CoolnsX

While macs logger does accept a -t argument, it's broken. source Since almost nothing uses logger on mac, we can just search for logger

port19x avatar Jul 07 '24 08:07 port19x

Let's merge this after the other two PRs that are currently open

port19x avatar Jul 16 '24 06:07 port19x

Given that #1372 has stalled, I'd like to merge this sometime this week. Ideally after dealing with the two plattform refinements for steamdeck and mac os

port19x avatar Jul 29 '24 08:07 port19x

Closes #1374

port19x avatar Aug 20 '24 10:08 port19x

finally

71zenith avatar Aug 23 '24 14:08 71zenith

Github release coming up a little later, gotta make time to write release notes

port19x avatar Aug 26 '24 13:08 port19x