feat: initial logger support
Pull Request Template
Type of change
- [ ] Bug fix
- [ ] Feature
- [ ] Documentation update
Description
ramble here
Checklist
- [ ] any anime playing
- [ ] bumped version
- [ ] next, prev and replay work
- [ ]
-chistory and continue work - [ ]
-ddownloads work - [ ]
-ssyncplay works - [ ]
-qquality works - [ ]
-vvlc works - [ ]
-eselect episode works - [ ]
-Sselect index works - [ ]
-rrange selection works - [ ]
--skipani-skip works - [ ]
--skip-titleani-skip title argument works - [ ]
--no-detachno detach works - [ ]
--duband regular (sub) mode both work - [ ] all providers return links (not necessarily on a single anime, use debug mode to confirm)
- [ ]
-hhelp info is up to date - [ ] Readme is up to date
- [ ] Man page is up to date
Additional Testcases
- The safe bet: One Piece
- Episode 0: Saenai Heroine no Sodatekata ♭
- Unicode: Saenai Heroine no Sodatekata ♭
- Non-whole episodes: Tensei shitara slime datta ken (ep. 24.5, ep. 24.9)
@port19x it seems that journalctl cleans up the logs every few days? do u still wanna proceed with this feature
:/
@port19x it seems that journalctl cleans up the logs every few days? do u still wanna proceed with this feature
That's configured by the distro, on arch I still have logs from march. I'd say let's proceed
i'd like someone to test this on mac @justchokingaround free?
I have a m1 macbook air that I bought used like 2 weeks ago. I can do the testing if I remember
@port19x did u test?
I didn't forget to check, but I forgot this is already done, since it's still a draft PR. I was confused by your inactivity. Will test later today
Not quite there yet. Ani-cli -l hangs
can u check the docs to see how to print the logs. its hard for me to rely on stack overflow and random forums
Yeah, but might not get to it today
I had to take care of an elephant this weekend. I'll see that I get this done sometime this week.
the elephant in question
I had to take care of an elephant this weekend. I'll see that I get this done sometime this week.
the elephant in question
Noice, well it's a great language, and it will be like a stain on ur life 🙃
While macs logger does accept a -t argument, it's broken.
source
Since almost nothing uses logger on mac, we can just search for logger
Let's merge this after the other two PRs that are currently open
Given that #1372 has stalled, I'd like to merge this sometime this week. Ideally after dealing with the two plattform refinements for steamdeck and mac os
Closes #1374
finally
Github release coming up a little later, gotta make time to write release notes