helm-chart icon indicating copy to clipboard operation
helm-chart copied to clipboard

fix: allow arbitrary env keys eg valueFrom

Open lizthegrey opened this issue 4 years ago • 2 comments

lizthegrey avatar Dec 24 '21 00:12 lizthegrey

Testing this against my own vendored copy, will report back...

lizthegrey avatar Dec 24 '21 00:12 lizthegrey

Thank you for the contribution @lizthegrey!

Yeah, I think we should keep the current behavior of env for backward compatibility. We can introduce an additional variable, although it will be difficult to combine them.

Alternatively, since the main scenario for this is using secrets, we could use the envFrom directive:

{{- if .Values.envFromSecret }}
envFrom:
- secretRef:
    name: {{ .Values.envFromSecret }}
{{- end }}

kolesnikovae avatar Dec 24 '21 20:12 kolesnikovae