Add start_date, end_date & pagination parameters
In order to facilitate data science management I have refactored the endpoint "fetch_media" : I have added a start_date, an end_date to gather images during this time period and a pagination parameter in order to get images 10 by ten
=> still need to adapt pyro-client and to add test in the client part
Codecov Report
Attention: Patch coverage is 91.66667% with 2 lines in your changes missing coverage. Please review.
Project coverage is 94.27%. Comparing base (
767be30) to head (571e3c5). Report is 26 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| src/app/api/endpoints/media.py | 88.23% | 2 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #324 +/- ##
==========================================
- Coverage 94.54% 94.27% -0.27%
==========================================
Files 63 66 +3
Lines 1594 1695 +101
==========================================
+ Hits 1507 1598 +91
- Misses 87 97 +10
| Flag | Coverage Δ | |
|---|---|---|
| client | 90.58% <ø> (?) |
|
| unittests | 94.47% <91.66%> (-0.07%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
some thoughts / questions : => this PR is useless, I should I have implemented the pagination code in the client part, not in the API part, no ? => Can I add the boto dependency in the client ? => instead of using fetch_media I should have used get_media_url => Mateo needs Alerts + URL
I think the pagination idea is great for all the "fetch" routes, perhaps we should revisit this for all endpoints. Some rebasing is needed first though :sweat_smile:
Yes I will go back to this pagination after the end of the big refactor :) I think I will create a brand new PR