pyro-api icon indicating copy to clipboard operation
pyro-api copied to clipboard

Save media in a "site" bucket

Open RonanMorgan opened this issue 1 year ago • 1 comments

Pyronear

This is a first step to start this refactor : gathering images per site / installation.

RonanMorgan avatar May 03 '24 08:05 RonanMorgan

Codecov Report

Attention: Patch coverage is 69.44444% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 94.43%. Comparing base (767be30) to head (8dd60c1).

Files Patch % Lines
src/app/api/endpoints/media.py 63.63% 4 Missing :warning:
src/app/services/storage.py 60.00% 4 Missing :warning:
src/app/api/deps.py 83.33% 2 Missing :warning:
src/app/services/services.py 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #323      +/-   ##
==========================================
- Coverage   94.54%   94.43%   -0.11%     
==========================================
  Files          63       63              
  Lines        1594     1600       +6     
==========================================
+ Hits         1507     1511       +4     
- Misses         87       89       +2     
Flag Coverage Δ
unittests 94.43% <69.44%> (-0.11%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 03 '24 09:05 codecov[bot]

Thanks for the PR :) The description mostly comes from the illustration, so am I understanding this clearly: we create one bucket per entity (organization now I guess?)

frgfm avatar Jun 23 '24 18:06 frgfm

well the schema is a bit outdated : I did some calculation with OVH Cold Archive vs OVH S3 and for now it would cose only few euros to keep years of data

but yes I would like to have one bucket per organization :)

RonanMorgan avatar Jun 24 '24 07:06 RonanMorgan