feat: add fields to store when an event was acknowledged and by whom
To address #274 , this PR adds acknowledged_ts and acknowledged_by to events table
Nice of you to open a PR :pray:
When you're ready and want to get it reviewed, post a comment in this Pull Request with this message: /quack review
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 95.38%. Comparing base (
fa2624d) to head (6d67f43). Report is 62 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #278 +/- ##
==========================================
+ Coverage 95.12% 95.38% +0.26%
==========================================
Files 63 66 +3
Lines 1497 1582 +85
==========================================
+ Hits 1424 1509 +85
Misses 73 73
| Flag | Coverage Δ | |
|---|---|---|
| client | 100.00% <ø> (?) |
|
| unittests | 95.15% <100.00%> (+0.03%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks @fe51 ! There was a problem that caused the client tests to fail: I was recording the access_id instead of the user_id in events/acknowledge_by. This is fixed now.
Thanks a lot @blenzi
Closing as this was for the legacy data model, feel free to reopen if I missed something!