numpyro icon indicating copy to clipboard operation
numpyro copied to clipboard

Use type hints whenever possible

Open neerajprad opened this issue 6 years ago • 6 comments

Since we are using python 3, we can start taking advantage of type hints wherever possible.

neerajprad avatar Aug 27 '19 00:08 neerajprad

we should probably do this in pyro too

jpchen avatar Aug 27 '19 04:08 jpchen

@neerajprad @jpchen Could I work on this issue?

akihironitta avatar Oct 10 '20 10:10 akihironitta

@akihironitta - The codebase and number of contributors to numpyro core is small enough that this is low priority for us at the moment. When I created the issue, I was thinking that we could do this in a piecemeal fashion as we were refactoring the codebase. If you are interested, my suggestion would be to start with one of the other tasks and refactor to use type hints on the internal code that your PR touches.

neerajprad avatar Oct 11 '20 18:10 neerajprad