packaging icon indicating copy to clipboard operation
packaging copied to clipboard

Fix prerelease detection for `>` and `<`

Open notatallshaw opened this issue 1 year ago • 4 comments

Fixes https://github.com/pypa/packaging/issues/788

And adds an explicit test for != based on https://github.com/pypa/packaging/issues/776#issuecomment-1900515985

notatallshaw avatar Apr 13 '24 17:04 notatallshaw

Feedback would be appreciated.

notatallshaw avatar May 18 '24 14:05 notatallshaw

And adds an explicit test for !=

Is this for another PR? I don’t see the change here.

uranusjr avatar May 20 '24 16:05 uranusjr

And adds an explicit test for !=

Is this for another PR? I don’t see the change here.

It's in this PR, it's in the change to tests/test_specifiers.py

notatallshaw avatar May 20 '24 16:05 notatallshaw

I tried to merge branch with 'main' to make sure this PR was still good, but forgot I don't have automatic CI rights, if someone could approve CI run I'd be appreciative.

notatallshaw avatar Jul 12 '24 21:07 notatallshaw

Anything blocking this? Do I need to do anything for a changelog entry here?

notatallshaw avatar Aug 04 '24 22:08 notatallshaw

#788 (comment) has some examples. We probably should have some tests for those.

Added specifier tests to match.

notatallshaw avatar Aug 16 '24 23:08 notatallshaw

The specifics of this came up today in https://github.com/astral-sh/uv/issues/6640

It reminded me to check this PR, it seems there was a transient CI error, I added some more tests (and after correcting them) the transient CI error vanished.

notatallshaw avatar Aug 26 '24 23:08 notatallshaw

I'm going to give @pradyunsg a chance to (dis)agree to the semantic change before I merge.

brettcannon avatar Sep 16 '24 16:09 brettcannon

Thanks, @notatallshaw !

brettcannon avatar Sep 16 '24 22:09 brettcannon