Pyfa icon indicating copy to clipboard operation
Pyfa copied to clipboard

Database integrity issue when loading fit with invalid boosters

Open blitzmann opened this issue 5 years ago • 0 comments

Bug Report

If a booster is considered invalid when the fit is loaded, the booster is removed. However, the booster side effects are not also removed. This causes integrity exceptions when you attempt to add a new booster to any fit (SQLAlchemy will attempt to reuse the ID that was removed, but that conflicts with the side effects, and things just break)

image

This is very much an edge case - it's very rare that we store an invalid item as a booster, and rare that eve data update will render it invalid without us intervening with some migration script. It's more a sanity check thing, but should be fixed at some point to remove the side effects when the booster is removed

blitzmann avatar Jun 28 '20 04:06 blitzmann