ipfilter icon indicating copy to clipboard operation
ipfilter copied to clipboard

Trusts addresses from the client provided X-Forwarded-For header

Open Gunni opened this issue 6 years ago • 1 comments

Arrive at a page blocked using ipfilter.

Spoof the X-Forwarded-For header with a permitted IP.

Refresh.

Access granted...

Gunni avatar Jul 11 '19 22:07 Gunni

Just discovered the strict keyword, not documented on https://caddyserver.com/docs/http.ipfilter

This behaviour is a bad default.

Suggestion: default to strict but allow the admin to provide an array of trusted proxy IPs where you can trust this header.

Gunni avatar Jul 11 '19 22:07 Gunni