pybricks-micropython icon indicating copy to clipboard operation
pybricks-micropython copied to clipboard

pbio/sys/hmi: Reduce time needed to power off hub.

Open laurensvalk opened this issue 1 year ago • 3 comments

Reduces the power off time from 3 to 2 seconds. This has been requested occasionally. I think this is OK.

If it makes certain use cases harder, like long press menus, we could now quite easily add a user setting to make this timeout configurable due to https://github.com/pybricks/support/issues/1622 now being implemented.

laurensvalk avatar Jun 07 '24 12:06 laurensvalk

Coverage Status

coverage: 56.592%. remained the same when pulling c13bcdab68ae5b90336a7c6f9aef0cbc3cff1923 on storage into 83e372a3cf392101bef1314b711a64bbad96a510 on master.

coveralls avatar Jun 07 '24 12:06 coveralls

This was requested among others by @biasedlogic.

laurensvalk avatar Jun 07 '24 12:06 laurensvalk

Coverage Status

coverage: 56.592%. remained the same when pulling 42f10e1917349c1a6aa2e0326601cbd4f8a218c9 on storage into 5a240996b2ad57b80aefe26be0f65ec0265ae2cc on master.

coveralls avatar Jul 22 '24 11:07 coveralls

We will merge this since there haven't been any objections for a month. If anyone needs a longer shutdown-time out, please feel free to open a new issue. Then we make make the duration a user-configurable setting. Perhaps as a second argument to the existing set_stop_button method.

laurensvalk avatar Jul 22 '24 11:07 laurensvalk