Benchmarks failing

Open Saransh-cpp opened this issue 10 months ago • 2 comments

All the benchmarks (except the validation ones, because they are commented out) are failing (periodic, on_push). We need a better way (maybe a badge in the README) to display the failures as they have been failing for quite some time now and no one has noticed it.

I haven't looked into the failure, but I am guessing that they are still using some old PyBaMM code.

Mar 30 '25 16:03 Saransh-cpp

So it looks like the benchmarks are alright, they are just failing because of this issue: https://github.com/pympler/pympler/issues/151, caused by a specific benchmark that didn't occur before for earlier versions of Pympler. We can disable the relevant benchmark if it helps.

Mar 30 '25 18:03 agriyakhetarpal

Sounds good!

Mar 30 '25 22:03 Saransh-cpp