PyBaMM icon indicating copy to clipboard operation
PyBaMM copied to clipboard

[Bug]: `pybamm.Simulation.set_parameters` and `pybamm.Simulation.set_up_and_parameterise_experiment` made private in `simulation.py`

Open Akhil-Sharma30 opened this issue 1 year ago • 1 comments

Description

pybamm.Simulation.set_parameters, pybamm.Simulation.set_up_and_parameterise_experiment and pybamm.Simulation.set_up_and_parameterise_model_for_experiment made private in pybamm/simulation.py (continuation of #3752 PR)

Fixes #3751

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Optimization (back-end change that speeds up the code)
  • [ ] Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • [ ] No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • [ ] All tests pass: $ python run-tests.py --all (or $ nox -s tests)
  • [ ] The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

Further checks:

  • [ ] Code is commented, particularly in hard-to-understand areas
  • [ ] Tests added that prove fix is effective or that feature works

Akhil-Sharma30 avatar Oct 04 '24 10:10 Akhil-Sharma30

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 99.25%. Comparing base (bcdd0b5) to head (4051fb6). Report is 173 commits behind head on develop.

Files with missing lines Patch % Lines
src/pybamm/simulation.py 66.66% 3 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4489      +/-   ##
===========================================
- Coverage    99.26%   99.25%   -0.02%     
===========================================
  Files          302      302              
  Lines        22889    22897       +8     
===========================================
+ Hits         22721    22726       +5     
- Misses         168      171       +3     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 10 '24 13:10 codecov[bot]

@Akhil-Sharma30 I just fixed a couple small things, should be good for now

kratman avatar Nov 19 '24 01:11 kratman