PyBaMM icon indicating copy to clipboard operation
PyBaMM copied to clipboard

Update windows logic for JAX in Nox and remove redundant Homebrew installations

Open kratman opened this issue 1 year ago • 3 comments

Followup to comments from @agriyakhetarpal in #3932

Changing settings for the JAX build was outside the scope of the other ticket, so this one is my reminder to go fix the issues.

We can now remove the sys.platform != "win32" checks from everywhere in the file because all dependencies will now support all platforms

The only condition we will still need should be the Python <3.9 version check (where JAX is not available)

kratman avatar Mar 28 '24 13:03 kratman

I will also look into the DAE modulo test from #3932 that caused a tiny drop in coverage

kratman avatar Mar 29 '24 12:03 kratman

On another note, we shouldn't need to install two of the macOS system dependencies now with this, just graphviz and libomp should be required. We are fine with using Accelerate as a BLAS vendor and we needed gcc to get gfortran earlier for compiling scikits.odes (it wasn't being used for compiling IDAKLU anyway, we used the system Clang for that). I guess these changes would probably be better in a separate PR.

cross-posted from #3932 (comment)

agriyakhetarpal avatar Mar 29 '24 16:03 agriyakhetarpal

All that should be left in this ticket is the modulo test. I will work on getting that sorted out this week

kratman avatar Apr 02 '24 15:04 kratman