PyBaMM icon indicating copy to clipboard operation
PyBaMM copied to clipboard

BaseBatterySubmodel

Open rtimms opened this issue 3 years ago • 2 comments

Make a BaseBatterySubmodel that performs things like checking domains, e.g.

        ok_domain_list = [
            "Negative",
            "Separator",
            "Positive",
            "Negative electrode",
            "Negative electrolyte",
            "Separator electrolyte",
            "Positive electrode",
            "Positive electrolyte",
            None,
        ]

so that BaseSubmodel is more general. Useful for training etc. to not be restricted to battery things when using submodels.

rtimms avatar Aug 09 '22 10:08 rtimms

We could consider getting rid of those checks.

valentinsulzer avatar Aug 09 '22 21:08 valentinsulzer

Following our experience with the coord_sys, I think we should keep some checks somewhere in the battery submodels. But certainly not in the BaseSubmodel class.

brosaplanella avatar Aug 10 '22 08:08 brosaplanella