PyBaMM icon indicating copy to clipboard operation
PyBaMM copied to clipboard

Variable renaming for composite release

Open valentinsulzer opened this issue 3 years ago • 1 comments

Description

Some changes in preparation for the composite release. No functionality should be affected by this PR, it just introduces phase dependency that will then be used by the composite release. This is in a separate PR to reduce the PR size.

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Optimization (back-end change that speeds up the code)
  • [ ] Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • [ ] No style issues: $ flake8
  • [ ] All tests pass: $ python run-tests.py --unit
  • [ ] The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • [ ] Code is commented, particularly in hard-to-understand areas
  • [ ] Tests added that prove fix is effective or that feature works

valentinsulzer avatar Jul 08 '22 17:07 valentinsulzer

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Codecov Report

Merging #2166 (ad8f81c) into develop (2f3c3fa) will decrease coverage by 0.25%. The diff coverage is 95.27%.

@@             Coverage Diff             @@
##           develop    #2166      +/-   ##
===========================================
- Coverage    99.36%   99.11%   -0.26%     
===========================================
  Files          355      356       +1     
  Lines        19499    19736     +237     
===========================================
+ Hits         19375    19561     +186     
- Misses         124      175      +51     
Impacted Files Coverage Δ
...ybamm/models/full_battery_models/lead_acid/full.py 100.00% <ø> (ø)
...dels/full_battery_models/lead_acid/higher_order.py 98.16% <ø> (ø)
...ybamm/models/full_battery_models/lead_acid/loqs.py 100.00% <ø> (ø)
...bamm/models/full_battery_models/lithium_ion/mpm.py 100.00% <ø> (ø)
.../submodels/particle_mechanics/crack_propagation.py 100.00% <ø> (ø)
...submodels/active_material/total_active_material.py 22.22% <22.22%> (ø)
.../submodels/interface/kinetics/diffusion_limited.py 96.55% <66.66%> (-1.67%) :arrow_down:
...kinetics/inverse_kinetics/inverse_butler_volmer.py 98.46% <66.66%> (-1.54%) :arrow_down:
pybamm/parameters/parameter_values.py 98.67% <76.92%> (-0.79%) :arrow_down:
...etics/first_order_kinetics/first_order_kinetics.py 97.36% <80.00%> (-2.64%) :arrow_down:
... and 62 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 17 '22 18:08 codecov[bot]

Closing and will reopen composite-release-parameters to take care of the coverage

valentinsulzer avatar Aug 18 '22 11:08 valentinsulzer