PyBaMM icon indicating copy to clipboard operation
PyBaMM copied to clipboard

Add option to include heat of mixing

Open rtimms opened this issue 4 years ago • 2 comments

Add an option to include heat of mixing (irreversible) and use the expression for the reversible heating from this paper

rtimms avatar Nov 03 '21 13:11 rtimms

Hey @rtimms , I'm interested in PyBamm for GSoC22 and I wanna work on this issue. I went through the abstract and few parts of the paper that explains the equations of importance- Eq. (26) and (27) But, I don't have a background on battery physics, so it's a bit complex for me to identify where the heat of mixing comes into picture in the equation and the corresponding file/class that needs changing. Can you help me with that

srinathkp avatar Apr 14 '22 07:04 srinathkp

You need to incorporate the extra terms in base_thermal.py (in _get_standard_coupled_variables l90). You basically need to define the extra terms, which correspond to equations (20)-(21) of the published version (let me know if you can't access it). Note that you need to handle full cell and half-cell differently (like some other terms already do).

brosaplanella avatar Apr 14 '22 08:04 brosaplanella

Hackathon info

This will be one of the projects for the first PyBaMM Hackathon. Here you can find some information (summarising other points made on this issue) which should be a useful starting point. Note that this post will evolve, even during the Hackathon day, so make sure to check it regularly.

Background

Currently, PyBaMM includes various heat generation mechanisms in its thermal models (see base_thermal.py), for example reversible heating or Ohmic heating. At the moment it does not include the heat of mixing, as defined in equations (20)-(21) of Richardson & Korotkin (2021).

The aim of this project is to include this extra heat source term, and add an option to base_battery_model.py to enable or disable this heat source term to allow comparisons.

Tasks

  • [ ] Implement the additional heat source term in base_thermal.py. Special attention needs to be paid to ensure the right concentration (e.g. x-averaged or not) is used for each model.
  • [x] Add an option to base_battery_model.py which allows to switch on/off this source term.
  • [x] Write an example that shows how to include this source term and compares the same model with/without it.
  • [ ] Ensure coverage and tests pass.

brosaplanella avatar Mar 06 '23 09:03 brosaplanella

https://github.com/abillscmu/git-practice

@smitasahu2 @abillscmu @Afgr1087 @ikorotkin @geslina

brosaplanella avatar Mar 29 '23 09:03 brosaplanella

https://github.com/abillscmu/PyBaMM

Install from source instructions

brosaplanella avatar Mar 29 '23 10:03 brosaplanella