chatkit-android icon indicating copy to clipboard operation
chatkit-android copied to clipboard

SDK version value should reflect the version of the SDK, not the version of the app

Open zmarkan opened this issue 6 years ago • 2 comments

Right now, it's taking whatever version the app is taking (see below link). It should instead take the version of the Chatkit SDK from the file releases.

https://github.com/pusher/chatkit-android/blob/dc42f8ea3bd9c877b21acf0ad9a9bd9d4a79f9bb/chatkit-android/src/main/kotlin/com/pusher/chatkit/AndroidChatkitDependencies.kt#L29

zmarkan avatar Aug 19 '19 15:08 zmarkan

Actually, it might refer to the version here: https://github.com/pusher/chatkit-android/blob/master/chatkit-android/build.gradle#L19

It's possible to move the version assignment into an external variable and increment it there for both bintray version as well as for the buildConfig version.

zmarkan avatar Aug 19 '19 15:08 zmarkan

We're looking at updating this process for v2 - watch this space 🙂

daniellevass avatar Mar 06 '20 15:03 daniellevass