push-dapp icon indicating copy to clipboard operation
push-dapp copied to clipboard
verified publisher icon push-protocol

Changed featured list

Open HarshRajat opened this issue 1 year ago • 3 comments

Pull Request Template

Ticket Number

#1896

  • Problem/Feature: Updated Feature List

Type of Change

  • [ ] Bug fix
  • [ ] New feature
  • [ ] Code refactor
  • [ ] Documentation update
  • [X] Other (please describe): Updated Channel Feature List

Checklist

  • [X] Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
    • [X] Quick PR label added
  • [ ] Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
    • [ ] DO NOT Merge PR label added

Frontend Guidelines

Build & Testing

  • [ ] No errors in the build terminal
  • [ ] Engineer has tested the changes on their local environment
  • [ ] Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

  • Before: Explain the previous behavior

  • After: What's changed now

Additional Context

Review & Approvals

  • [ ] Self-review completed
  • [ ] Code review by at least one other engineer
  • [ ] Documentation updates if applicable

Notes

HarshRajat avatar Oct 05 '24 17:10 HarshRajat

  • In the environment variables section, there is a typo in VITE_APP_DEPLOY_ENV=DEV it should be VITE_APP_DEPLOY_ENV=DEV without the extra 'N' at the end.
  • There is an HTML declaration <!DOCTYPE html> that is misplaced. It should be at the very beginning of an HTML document.
  • There's no closing tag at the end of the script under the </script> module tag. It should be added to close the script element.
  • In the script section, the import statement should not be there as it is unrelated to the HTML structure. It should be moved to a separate TypeScript file.
  • In the TypeScript code section, there is a reference to appConfig that is not defined within the provided section. It should be imported from its appropriate source or defined within the same file.

All looks good.

github-actions[bot] avatar Oct 05 '24 17:10 github-actions[bot]

PR Preview Action v1.4.7 :---: Preview removed because the pull request was closed. 2024-10-07 05:34 UTC

github-actions[bot] avatar Oct 05 '24 17:10 github-actions[bot]

In the .env.sample file, there seems to be a typo in the comment for VITE_APP_NODE_ENV. It mentions DEPLOY_ENN instead of DEPLOY_ENV. Additionally, there's a duplicate content attribute in the meta tag for theme-color, and the comment for PUBLIC_URL is missing its closing tag.

In the index.html file, there are missing closing tags for the meta and link elements, multiple instances of name attribute without meta tag, and a missing closing tag for the meta tag related to theme-color.

In the public/index-dev.html file, the same issues present in index.html can be found, including missing closing tags and misplaced attributes.

For the other files not provided, it's recommended to verify that the structure and tags are correctly closed and nested as required.

Overall, there are several HTML syntax issues in the files provided that need to be fixed.

github-actions[bot] avatar Oct 05 '24 17:10 github-actions[bot]