documentation icon indicating copy to clipboard operation
documentation copied to clipboard

Proposed corrections and changes to getting started guide

Open oldfartdeveloper opened this issue 5 years ago • 3 comments

@milesfrain in attempting to reconcile Chapter 8's procedures w/ your explanation of how to do it, I combed through the Getting Started guide. In the process, I found some mistakes and added what I thought are a couple of desired missing details.

One judgement call I made was to have GitHub not track the user's my-project directory.

Hope this helps. I'll drop duplicated information in the chapter 8 document.

oldfartdeveloper avatar Jun 11 '20 19:06 oldfartdeveloper

Looks good in general. Just a few comments.

Regarding adding a section on rendering to browser, perhaps let that be a separate PR, since that may involve some additional discussion beyond these straightforward corrections.

milesfrain avatar Jun 11 '20 23:06 milesfrain

I'll make your corrections, thanks.

In addition, per our discussion here, I'll add a PR to the code itself to use the diagonal exercise instead of Euler.

oldfartdeveloper avatar Jun 12 '20 19:06 oldfartdeveloper

@milesfrain all of your suggestions have been handled; this should be ready to merge.

oldfartdeveloper avatar Jun 12 '20 19:06 oldfartdeveloper

This PR hasn't been merged because it now seems a bit outdated

JordanMartinez avatar Dec 18 '22 15:12 JordanMartinez

@JordanMartinez you are correct; the issues I have addressed here are already in master on Dec 29, 2022.

Hence, closing this issue. I'll submit a new issue/PR for new minor issues that I found while checking the latest release soon.

oldfartdeveloper avatar Dec 29 '22 21:12 oldfartdeveloper