documentation icon indicating copy to clipboard operation
documentation copied to clipboard

Warning pages/skeletons all labelled as error

Open nwolverson opened this issue 8 years ago • 3 comments

All pages under errors/ appear (at a random sample) to be titled

SomeIssue Error

I propose those which are warnings rather than errors should be titled

SomeIssue Warning

nwolverson avatar Jan 04 '18 18:01 nwolverson

Is there a single place in the compiler which lists all warnings? I brief search can't find it. Is searching for shouldWarnWith the best way to find them?

If so, here's a list I made from that search.

  • [ ] DuplicateExportRef
  • [x] DuplicateImport
  • [x] DuplicateImportRef
  • [ ] DuplicateSelectiveImport
  • [x] HidingImport
  • [x] ImplicitImport
  • [x] ImplicitQualifiedImport
  • [ ] OverlappingPattern
  • [ ] MissingNewtypeSuperclassInstance
  • [ ] MissingTypeDeclaration
  • [ ] MissingTypeDeclaration
  • [ ] ScopeShadowing
  • [ ] ShadowedName
  • [ ] ShadowedTypeVar
  • [ ] UnnecessaryFFIModule
  • [x] UnusedDctorExplicitImport
  • [x] UnusedDctorImport
  • [x] UnusedExplicitImport
  • [ ] UnusedFFIImplementations
  • [x] UnusedImport
  • [ ] UnusedTypeVar
  • [ ] UserDefinedWarning
  • [ ] UnverifiableSuperclassInstance
  • [ ] WildcardInferredType

chexxor avatar Jan 15 '18 20:01 chexxor

I don't think there is, as there is no real distinction between error and warning - they are raised in a different way, rather than having errorness/warningness built into the type itself.

The changes in https://github.com/purescript/documentation/pull/159 should check off a bunch of these.

nwolverson avatar Jan 15 '18 21:01 nwolverson

Ok, I checked-off the warnings you added in that MR. Great progress!

chexxor avatar Jan 15 '18 22:01 chexxor