puppetlabs-puppet_agent Add Debian package pin to stop the version changing on apt upgrade

When on Debian and a package version is specified we should also create a Debian package pin to stop apt upgrade from changing the version just for the next puppet run to change it back.

May 28 '19 14:05 ddryden

Waiting for CLA signature by @ddryden

@ddryden - We require a Contributor License Agreement (CLA) for people who contribute to Puppet, but we have an easy click-through license with instructions, which is available at https://cla.puppet.com/

Note: if your contribution is trivial and you think it may be exempt from the CLA, please post a short reply to this comment with details. http://docs.puppet.com/community/trivial_patch_exemption.html

May 28 '19 20:05 puppetcla

CLA signed by all contributors.

Jun 03 '19 15:06 puppetcla

How is this PR going? Is the requested change the only thing blocking the merge? The CI seems to be failing because of missing dependencies in the test suite.

I'd love to see this merged & released :)

Sep 26 '19 09:09 seoester

@seoester, there is small change needed from @ddryden

Sep 27 '19 11:09 ciprianbadescu

@ciprianbadescu thanks for the quick response.

Would you mind if I replicated the PR and performed the change to speed things along?

Sep 27 '19 11:09 seoester

@seoester, would be OK. Pls also check https://github.com/puppetlabs/puppetlabs-puppet_agent/blob/master/CONTRIBUTING.md

Sep 27 '19 11:09 ciprianbadescu

Sorry for being slow to respond.

Your right 1001 would be a better priority.

I don't know my way around the test's could you link some documentation?

https://github.com/puppetlabs/puppetlabs-puppet_agent/blob/master/CONTRIBUTING.md seems to have a Testing section listed in the table of contents but does not exist in the document.

Oct 13 '19 15:10 ddryden

@ddryden, I replicated your PR and we have been discussing the changes in #441.

Oct 14 '19 10:10 seoester

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

Sep 01 '21 18:09 CLAassistant

Implementation is going a different route, and this PR can likely be closed https://github.com/puppetlabs/puppetlabs-puppet_agent/pull/441#issuecomment-948368554.

Oct 21 '21 08:10 seoester

@seoester Our puppetN-release packages on apt.puppet.com now install a preferences file (see https://github.com/puppetlabs/puppetlabs-release/commit/ecf2c8526e4cebc6229dd9c27fc1c7db25bba730#diff-4fbc9b1630d785c70cd453b814c99fa693faae74aabf983473e85ef200b3b32d) This was done because Debian and Ubuntu have started publishing puppet-agent packages with the same name as ours. Given that I'm thinking this is no longer needed?

Sep 24 '24 15:09 joshcooper

@joshcooper, thanks for the ping after so much time.

The pinning you are referencing pins the Apt Source/Repo of the puppet-agent package. The pinning proposed in this PR (and my PR #441) pins the specific version of the puppet-agent package, so that apt upgrade does not unintentionally bump the package to a new version.

I believe this specific PR can be closed in any case. That's because the team wanted to go a different route, using a new feature of the dpkg provider rather than apt pinning: https://github.com/puppetlabs/puppetlabs-puppet_agent/pull/441#issuecomment-549810369

Nov 06 '24 20:11 seoester

I believe this specific PR can be closed in any case.

@seoester thanks for letting us know.

Mar 12 '25 02:03 joshcooper