puppetdb icon indicating copy to clipboard operation
puppetdb copied to clipboard
verified publisher icon puppetlabs

(PDB-5519) Upgrade to honeysql v2

Open austb opened this issue 3 years ago • 4 comments

Blocked on https://github.com/puppetlabs/clj-parent/pull/351 which is blocked until after the upcoming release.

austb avatar Aug 08 '22 16:08 austb

Jenkins tests are failing because the method of pinning honeysql in this PR doesn't work when building an ezbake package. Once we get the update into clj-parent and no longer need the pin, those tests will pass.

austb avatar Aug 08 '22 17:08 austb

@austb are we ready to get this in?

jonathannewman avatar Sep 16 '22 14:09 jonathannewman

I had to make some substantive changes to our handling of group by/order handling, so I've been hoping to get @rbrw eyes on it and our PTO has been conflicting for the past weeks.

austb avatar Sep 16 '22 16:09 austb

I think continuing to target 8.x (main) for this change makes sense. Seems risky for 7.x / LTS.

jonathannewman avatar Sep 16 '22 16:09 jonathannewman