fpu icon indicating copy to clipboard operation
fpu copied to clipboard

Wrong parameter name C_FLAG in fpu_shared.sv?

Open tovine opened this issue 7 years ago • 2 comments

In the file fpu_shared.sv a parameter called C_FLAG is referred, which I can't find in the imported package fpu_defs.

   logic [C_FLAG-1:0] Flags_S;

I'm assuming it is a typo and that it should instead be C_FFLAG, or have I missed something?

tovine avatar May 15 '18 14:05 tovine

Also: where is C_TAG defined? Could not find it from the root directory of the top pulp project (after running update-ips.

It is referred to several places in fpu_shared.sv:

logic [C_TAG-1:0] Tag_D;
logic [C_TAG-1:0] Tag_DN;
logic [C_TAG-1:0]  TagDelayed_DP;
logic [C_TAG-1:0]  TagDelayed_DN;

tovine avatar May 15 '18 15:05 tovine

Update: after some digging I found that these constants were removed in this commit: https://github.com/pulp-platform/fpu/commit/ad74409f69e2597535809c93175bf42a4a274468#diff-33d976666548c67ed8fa812b20ddfe81

-   parameter C_FLAG    = 9;
-   parameter C_TAG     = 7;
+   parameter C_FFLAG         = 5;

I therefore assume that these modules are not really maintained at the moment or that the parameters come from somewhere else?

tovine avatar Jun 11 '18 13:06 tovine