Refactor network functions

Open lukamac opened this issue 2 years ago • 2 comments

While working on drone code, we noticed that there was redundant code in the network run function so I moved some code to the initializer. Alongside that I aligned a little bit more the common and gap9 network templates in hopes to merge them completely soon.

Nov 14 '23 22:11 lukamac

I see that checks have failed. Please check that the modifications do not alternate the tests. Additionally, it would be needed in future to also add tests for GAP9 in the CI

Nov 15 '23 08:11 ABurrello

Yes, I will fix the problems ofc. Regarding the gap9 tests in CI is a bit more difficult because we use the private gap_sdk. It is possible to add a test on our private gitlab, but it requires effort and time which I don't have right now. If anyone is interested in doing it, I can pass the info I have.

Nov 15 '23 09:11 lukamac