common_verification icon indicating copy to clipboard operation
common_verification copied to clipboard

Faisal/svm

Open fhaque60 opened this issue 1 year ago • 2 comments

This imports the sum_pkg.svh which is a base class library we will use to create test benches The code is uncompiled so wee will need to compile and fix any compile issues

fhaque60 avatar May 17 '24 18:05 fhaque60

@micprog

fhaque60 avatar May 17 '24 18:05 fhaque60

Thanks for reviewing it These base classes are meant as templates over which to build the testbench. The TODOs are notes to the testbench builder for step they have to do to complete the testbench implementation SVM stands for systemverilog methodology

Get Outlook for iOShttps://aka.ms/o0ukef


From: Michael Rogenmoser @.> Sent: Saturday, May 18, 2024 4:01:09 AM To: pulp-platform/common_verification @.> Cc: Faisal Haque @.>; Author @.> Subject: Re: [pulp-platform/common_verification] Faisal/svm (PR #7)

@micprog commented on this pull request.

It looks like this is still work in progress, so I converted to draft. Feel free to mark as ready for review when ready.


In svm/svm_pkg.svhhttps://github.com/pulp-platform/common_verification/pull/7#discussion_r1605760306:

  • virtual task run();
  • virtual task finish();
  • endclass
  • virtual class svm_trans;
  • string name;
  • svm_logger log;
  • virtual function svm_trans cp();
  • virtual task pr();
  • virtual function bit compare(svm_trans trans);
  • endclass
  • virtual class svm_generator extends svm_component;
  • svm_trans trans;
  • mailbox svm_trans gen2drvr_mbx;
  • virtual functiona svm_trans gen ();

⬇️ Suggested change

  • virtual functiona svm_trans gen ();
  • virtual function svm_trans gen ();

In svm/svm_pkg.svhhttps://github.com/pulp-platform/common_verification/pull/7#discussion_r1605760365:

@@ -0,0 +1,126 @@ +//SVM Base class lib: +//svm_component +//svm_trans +//svm_logger +//macros if any +//svm_generator +//svm_env +//svm_driver +//svm_monitor +//svm_scoreboard +//svm_test +//some useful typedefs +// +// +package svm_pkg;

Just out of curiosity, what does SVM stand for?


In svm/svm_pkg.svhhttps://github.com/pulp-platform/common_verification/pull/7#discussion_r1605760463:

  • //TODO: connect gen2drvr _mbx to generators' gen2drvr_mbx;
  • //TODO: replace durif in virtual interface declaration with appropriate
  • //interface name
  • //TODO:fill in the drive task
  • //TODO:define a constructor which should:
  • //a) create the mailbox
  • //b) provide a name for the driver

It looks like there are still a lot of todos

— Reply to this email directly, view it on GitHubhttps://github.com/pulp-platform/common_verification/pull/7#pullrequestreview-2064724099, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BIPB3SRI4IGFAPASEW2AXK3ZC4YHLAVCNFSM6AAAAABH4TJRYSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANRUG4ZDIMBZHE. You are receiving this because you authored the thread.Message ID: @.***>

fhaque60 avatar May 18 '24 16:05 fhaque60