Kevin Puetz

Results 66 comments of Kevin Puetz

Actually, it's a worse than that - config.VMXTemplatePath is https://www.packer.io/docs/builders/vmware/iso#vmx_template_path - it's an input template file, not the .vmx we're going to write, which is https://github.com/hashicorp/packer-plugin-vmware/blob/274f4049159f7ada33bd0742c72c0ef27fee59d7/builder/vmware/iso/step_create_vmx.go#L335 much later in the...

> So a way to go would be to store the -rc.1.#build_counter as properties in Artifactory, you upload the name/v1.2.3 But this semes like of wrecks immutability for any developer...

Also, at least according to the docs https://learn.microsoft.com/en-us/cpp/preprocessor/preprocessor-experimental-overview?view=msvc-170#comma-elision-in-variadic-macros, `__VA_OPT__` has been available (in the new preprocessor only) since Visual Studio 16.5, which is _MSV_VER 1925, not 1940 (visual studio 17.10)...

I did find https://developercommunity.visualstudio.com/t/__VA_OPT__-should-be-enabled-by-std:c/10565399?sort=newest&ftype=problem confirming the original issue (that `__VA_OPT__` is not available, even in c++20 mode, unless you've also set `/Zc:preprocessor`, and this is not on by default.

> That wording seems to have been [added in Feb 2024](https://github.com/MicrosoftDocs/cpp-docs/commit/aa208734f78a6b4cf1347ff6168d98a6c990d7f7), which would line up with the 17.10 previews I found specific confirmation that this change (enabling __VA_OPT even for...

> If you can make a reproducer in the github actions CI Done, see dcb489c448f266c910a8c6a538beed6c6112b043 and https://github.com/puetzk/trompeloeil/actions/runs/14110751749 > I am a little bit hampered by not having a working MSVC...

Ok. No big rush for a release if you've got other stuff cooking, I've already turned on `/Zc:preprocessor` for the project where we hit this, and am happy to keep...

Another difference (that you're probably aware of, but I don't see it mentioned) is that Microsoft reserves the optional platform register from the [aapcs64](https://github.com/ARM-software/abi-aa/blob/main/aapcs64/aapcs64.rst#general-purpose-registers) (x18) to always point to the...

@thorntonryan found another clue: this seems related to #17627 and #17637. If I do `conan install --build compatible` on my minimized test case then it *does* succeed, and I get...

I'm aware of the `validate`/`validate_build` distinction, but I don't think they cover everything. They are documented as > The validate() method can be used to mark a package binary as...