Clear Offline Cache button updated to be blue (GCI Task)
Fixes #1318
- [x] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with
npm test - [ ] code is in uniquely-named feature branch and has no merge conflicts
- [x] PR is descriptively titled
- [x] ask
@publiclab/is-reviewersfor help, in a comment below - [x] Insert-step functionality is working correct as expected.
We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!
If tests do fail, click on the red X to learn why by reading the logs.
Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part Thanks!
Thanks for opening this pull request! There may be some errors, but don't worry! We're here to help! 👍🎉😄
@publiclab/is-reviewers I suppose I should call you for help. I'm not 100% sure if I can check off any boxes yet since I'm kind of confused what they mean.
Codecov Report
Merging #1358 into main will not change coverage. The diff coverage is
n/a.
@@ Coverage Diff @@
## main #1358 +/- ##
=======================================
Coverage 66.41% 66.41%
=======================================
Files 125 125
Lines 2552 2552
Branches 397 397
=======================================
Hits 1695 1695
Misses 857 857
@EC3x1903 Also for your questions about the checkboxes, you can check off the first one since as shown here, all of the tests have passed.

For the second checkbox, you generally want to put your code inside of a new branch labeled something like "make-cache-button-blue" to make it clear that the code inside of that branch is for that specific feature. You can read more about branches here.
For the third checkbox, your PR is pretty accurately named, so I think you can check it off. For the fourth checkbox, your comment satisfies that requirement so you should be all good to check off that one too. For the fifth checkbox, your code doesn't change anything with the inserting of steps at all so you should be able to check that one off too.
I myself am pretty new here (I'm also a student working with Public Lab for GCI) so if any of the mentors or more experienced people working on the project have any corrections, feel free to add them.
Would I need to open a new pull request to change the branch that I am requesting to push to the main repository?
@EC3x1903 you can follow the checkbox guidelines from the next PR. This is a small one so let it be.
@jywarren will gitpod not work on old PRs?
@jywarren will gitpod not work on old PRs?
I think it may need to be rebased, also there may be an issue with the originating branch in this PR?
Converting to draft, for now, feel free to mark it for review once you get time and push the requested changes :)