image-sequencer icon indicating copy to clipboard operation
image-sequencer copied to clipboard

Clear Offline Cache button updated to be blue (GCI Task)

Open ghost opened this issue 6 years ago • 9 comments

Fixes #1318

  • [x] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
  • [ ] code is in uniquely-named feature branch and has no merge conflicts
  • [x] PR is descriptively titled
  • [x] ask @publiclab/is-reviewers for help, in a comment below
  • [x] Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part Thanks!

ghost avatar Dec 14 '19 21:12 ghost

Thanks for opening this pull request! There may be some errors, but don't worry! We're here to help! 👍🎉😄

welcome[bot] avatar Dec 14 '19 21:12 welcome[bot]

@publiclab/is-reviewers I suppose I should call you for help. I'm not 100% sure if I can check off any boxes yet since I'm kind of confused what they mean.

ghost avatar Dec 14 '19 21:12 ghost

Codecov Report

Merging #1358 into main will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1358   +/-   ##
=======================================
  Coverage   66.41%   66.41%           
=======================================
  Files         125      125           
  Lines        2552     2552           
  Branches      397      397           
=======================================
  Hits         1695     1695           
  Misses        857      857

codecov[bot] avatar Dec 14 '19 22:12 codecov[bot]

@EC3x1903 Also for your questions about the checkboxes, you can check off the first one since as shown here, all of the tests have passed. image

For the second checkbox, you generally want to put your code inside of a new branch labeled something like "make-cache-button-blue" to make it clear that the code inside of that branch is for that specific feature. You can read more about branches here.

For the third checkbox, your PR is pretty accurately named, so I think you can check it off. For the fourth checkbox, your comment satisfies that requirement so you should be all good to check off that one too. For the fifth checkbox, your code doesn't change anything with the inserting of steps at all so you should be able to check that one off too.

I myself am pretty new here (I'm also a student working with Public Lab for GCI) so if any of the mentors or more experienced people working on the project have any corrections, feel free to add them.

rcya1 avatar Dec 14 '19 23:12 rcya1

Would I need to open a new pull request to change the branch that I am requesting to push to the main repository?

ghost avatar Dec 15 '19 03:12 ghost

@EC3x1903 you can follow the checkbox guidelines from the next PR. This is a small one so let it be.

harshkhandeparkar avatar Dec 15 '19 08:12 harshkhandeparkar

@jywarren will gitpod not work on old PRs?

harshkhandeparkar avatar Jul 07 '20 18:07 harshkhandeparkar

@jywarren will gitpod not work on old PRs?

I think it may need to be rebased, also there may be an issue with the originating branch in this PR?

jywarren avatar Aug 04 '20 16:08 jywarren

Converting to draft, for now, feel free to mark it for review once you get time and push the requested changes :)

harshkhandeparkar avatar Oct 17 '20 16:10 harshkhandeparkar