community-toolbox icon indicating copy to clipboard operation
community-toolbox copied to clipboard

List of people who've provided reviews or commented (supportively) on a PR

Open jywarren opened this issue 7 years ago • 8 comments

In the spirit of recognizing mutual support, (related to #14) we should recognize who is helping others; esp. since so many people begin to help others take their first step soon after completing their own first-timers-only issue!

Should be some way to pull at least formal reviewers list, but we could also, maybe, consider how we could count supportive comments on FTO issues?

jywarren avatar Mar 21 '19 17:03 jywarren

@jywarren we can take this as a GSOC issue

subhahu123 avatar Apr 14 '19 15:04 subhahu123

Hi, @jywarren and @subhahu123 is anyone working on this? Cause I would like to work on this.

YogeshSharma01 avatar Jan 31 '21 16:01 YogeshSharma01

@YogeshSharma01 do you have any idea how to implement this, it would be great if you can share.

govindgoel avatar Jan 31 '21 16:01 govindgoel

We'd love help with this. I think it may take some pretty significant API work -- looking at existing code in this repo plus a close look at the GitHub API to see what calls would be necessary!

jywarren avatar Feb 10 '21 15:02 jywarren

@jywarren I have an idea, we can retrieve the username from the API's mentioned below and append all unique username, and then list similarly as FTO authors.

Here is an example of GitHub API for retrieving a member who commented on a PR.

https://api.github.com/repos/publiclab/community-toolbox/issues/169/comments

This is an example of GitHub API for retrieving a member who reviewed a PR

https://api.github.com/repos/publiclab/community-toolbox/pulls/422/reviews

govindgoel avatar Feb 10 '21 16:02 govindgoel

That looks great! Shall we split this in two for commenters vs. reviewers, or just make 2 calls and merge? Thanks!

On Wed, Feb 10, 2021 at 11:34 AM Govind Goel [email protected] wrote:

@jywarren https://github.com/jywarren I have an idea, we can retrieve the username from the API's mentioned below and append all unique username, and then list similarly as FTO authors.

Here is an example of GitHub API for retrieving a member who commented on a PR.

https://api.github.com/repos/37signals/sub/issues/37/comments

This is an example of GitHub API for retrieving a member who reviewed a PR

https://api.github.com/repos/publiclab/community-toolbox/pulls/422/reviews

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/community-toolbox/issues/169#issuecomment-776839603, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAF6JYM2SXZ4FB6AUDCA5DS6KYRDANCNFSM4HAHXRVQ .

jywarren avatar Feb 10 '21 17:02 jywarren

I think we should split these and list them as sometimes a comment can just be for assigning or closing the issue.

govindgoel avatar Feb 10 '21 17:02 govindgoel

OK, that's great then. Let's start with just reviewers, shall we?

jywarren avatar Feb 11 '21 17:02 jywarren