PublicLab.Editor icon indicating copy to clipboard operation
PublicLab.Editor copied to clipboard

Updated font format in section 3

Open NitinMore7 opened this issue 7 years ago • 6 comments

Fixes #251

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • [x] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt jasmine
  • [ ] code is in uniquely-named feature branch and has no merge conflicts
  • [x] PR is descriptively titled
  • [x] PR body includes fixes #0000-style reference to original issue #
  • [x] ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

NitinMore7 avatar Jan 24 '19 12:01 NitinMore7

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests. There may be some errors, but don't worry! We're here to help! 👍🎉😄

welcome[bot] avatar Jan 24 '19 12:01 welcome[bot]

@gauravano may I review this PR? Also, just to confirm, when we are changing just a tag in the HTML, updating examples\index.html is enough or do we have to update javascripts\fixures\index.html and other files too?

IgorWilbert avatar Jan 24 '19 15:01 IgorWilbert

@IgorWilbert Please do! Also, no, there's no need to update fixtures.

rexagod avatar Jan 25 '19 03:01 rexagod

@NitinMore7 I just added Fixes #[issue-number] to the PR body and advice you to do so too as it closes the issue automatically on PR merge. Also, try to open PR on uniquely-named feature branch instead of master.

Thanks!

grvsachdeva avatar Feb 18 '19 09:02 grvsachdeva

Hi @rexagod @IgorWilbert, what do you think about this PR?

grvsachdeva avatar Feb 18 '19 09:02 grvsachdeva

@gauravano @NitinMore7 what's the current status of this PR?

VladimirMikulic avatar Jan 09 '20 02:01 VladimirMikulic