psignoret
Add Composer Compatability
Thanks for this pull request! Do you forsee any issues with the fact that I've taken firebase/php-jwt (under lib/php-jwt), prefixed the original namespace with "AADSSO/", but left it's original composer.json file in there?
wouldn't it need to be added as a dependency and then initialized with the autoloader?
On Thu, Nov 1, 2018 at 1:53 PM Philippe Signoret [email protected] wrote:
Thanks for this pull request! Do you forsee any issues with the fact that I've taken firebase/php-jwt (under lib/php-jwt), prefixed the original namespace with "AADSSO/", but left it's original composer.json file in there?
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/psignoret/aad-sso-wordpress/pull/208#issuecomment-435164741, or mute the thread https://github.com/notifications/unsubscribe-auth/AB8t2Yce-XGjYReiVa3YXr7-1F_M1PsTks5uq1FUgaJpZM4X1QZz .
-- Brad Kovach https://bradkovach.com
PGP key available at https://bradkovach.com/pgp If you need/want to send me an encrypted message, visit https://bradkovach.com/message
This change would not impact how firebase/php-jwt is currently included. If you wanted to later include firebase/php-jwt as a Composer dependency, you would need to first require it (composer require firebase/php-jwt) and rework the application a bit to allow the autoloader to include those files.
As far as this change is concerned, it just allows installing this plugin as a Composer dependency (otherwise we have to create a fork, add our own composer.json and then require as a dependency - as I did here)
