black icon indicating copy to clipboard operation
black copied to clipboard
verified publisher icon psf

Standardize type comments to form `# type: (value)` (#2097)

Open ranjodhsingh1729 opened this issue 10 months ago • 2 comments

Description

Fixes: #2097 – is_type_comment() is wrong

Summary of Changes:

  • Modified function signatures across several modules to pass the mode parameter to is_type_comment and make_comment.
  • Incorporated parts of PR #4467 by @Pedro-Muller29, particularly the fix in mode.py addressing the unhashable type: mode issue.

Acknowledgment: Credit to @Pedro-Muller29 for the initial work in PR #4467.

Any suggestions are welcome

Checklist - did you ...

  • [x] Add an entry in CHANGES.md if necessary?
  • [x] Add / update tests if necessary?
  • [ ] Add new / update outdated documentation?

ranjodhsingh1729 avatar Apr 07 '25 21:04 ranjodhsingh1729

@ranjodhsingh1729 any reasons for closing the PR? It's fairly large so I haven't found time to review it yet.

tusharsadhwani avatar Apr 20 '25 11:04 tusharsadhwani

@tusharsadhwani My Bad. I’m new to contributing and assumed I’d made an error when I saw no activity.

ranjodhsingh1729 avatar Apr 20 '25 14:04 ranjodhsingh1729