react-native-photo-editor icon indicating copy to clipboard operation
react-native-photo-editor copied to clipboard

Typescript issue

Open MakhouT opened this issue 5 years ago • 3 comments

When committing my git hooks gets activated and I am getting this error

$ tsc node_modules/react-native-photo-editor/index.tsx:56:14 - error TS7006: Parameter 'imagePath' implicitly has an 'any' type.

56 (imagePath) => { ~~~~~~~~~

node_modules/react-native-photo-editor/index.tsx:59:14 - error TS7006: Parameter 'resultCode' implicitly has an 'any' type.

59 (resultCode) => { ~~~~~~~~~~

Found 2 errors.

My tsconfig.js is as following:

  "compilerOptions": {
    "allowJs": true,
    "allowSyntheticDefaultImports": true,
    "esModuleInterop": true,
    "isolatedModules": true,
    "jsx": "react",
    "lib": ["es6"],
    "moduleResolution": "node",
    "skipLibCheck": true,    
    "noEmit": true,
    "strict": true,
    "target": "esnext"
  },
  "exclude": [ 
    "node_modules",    
    "babel.config.js", 
    "metro.config.js", 
    "jest.config.js"
  ]
}

Any ideas why this is still happening? Can we fix it?

MakhouT avatar Dec 09 '20 16:12 MakhouT

Experienced the same issue, I've added a fix in #166

DonovanDeSmedt avatar Dec 22 '20 15:12 DonovanDeSmedt

Thanks! Can confirm that it works!

MakhouT avatar Dec 23 '20 10:12 MakhouT

@prscX Can you please release? I am blocked by this. Thanks!

MakhouT avatar Dec 28 '20 09:12 MakhouT