lib icon indicating copy to clipboard operation
lib copied to clipboard

Automatically determine :ssl based on connection uri

Open reify-james-vickers opened this issue 3 years ago • 2 comments

protojure.grpc.client.providers.http2/connect takes a map that must contain :uri and can optionally contain :ssl with boolean value. It seems possible to automatically know that SSL should be used if the uri starts with https:// which is defining the connection scheme as HTTPS/SSL. Would it be possible to not have to provide :ssl in such cases then?

reify-james-vickers avatar May 06 '22 20:05 reify-james-vickers

Yes, definitely possible. The ssl field should remain for backwards compat, but we could make it have a default based on the scheme. I would consider a PR that implements this.

ghaskins avatar May 07 '22 02:05 ghaskins

https://github.com/protojure/lib/pull/136

reify-james-vickers avatar May 10 '22 16:05 reify-james-vickers