protobuf icon indicating copy to clipboard operation
protobuf copied to clipboard

Provide a Bzlmod module to support Bazel6

Open opicaud opened this issue 2 years ago • 13 comments

What language does this apply to? If it's a proto syntax change, is it for proto2 or proto3? No If it's about generated code change, what programming language? No

Describe the problem you are trying to solve. Being able to use protobuf as module in a Bazel project

Describe the solution you'd like Providing a MODULE.bazel file

Describe alternatives you've considered

Additional context Add any other context or screenshots about the feature request here. There is a draft here #12489 but not updated for April 2023, maybe @deannagarcia ?

If the request sounds valuable, i can contribute to provide the module file Olivier

opicaud avatar Aug 21 '23 15:08 opicaud

Thanks for the request! We are interested in moving to Bzlmod in the near future and are in communication with Bazel folks on our side. We are currently blocking on the completion of some work to restructure our repositories which will also affect our existing WORKSPACE dependencies.

We expect to start on the Bzlmod effort shortly after and can update back here once this is staffed.

We do already officially support Bazel 6, but the rest of #12489 moving to platforms is currently on hold .

zhangskz avatar Aug 23 '23 14:08 zhangskz

FYI @comius

meteorcloudy avatar Aug 31 '23 07:08 meteorcloudy

We triage inactive PRs and issues in order to make it easier to find active work. If this issue should remain active or becomes active again, please add a comment.

This issue is labeled inactive because the last activity was over 90 days ago.

github-actions[bot] avatar Nov 29 '23 10:11 github-actions[bot]

Still desired

aaliddell avatar Nov 29 '23 10:11 aaliddell

running into this issue with gazelle and protobuffs deps

bgdnvk avatar Dec 06 '23 11:12 bgdnvk

There are already patches under Bazel Central Registry to bring bzlmod support to protobuf. But only for several history versions. Is it possible to reuse those patches for the latest code?

railwaycat avatar Jan 04 '24 22:01 railwaycat

We triage inactive PRs and issues in order to make it easier to find active work. If this issue should remain active or becomes active again, please add a comment.

This issue is labeled inactive because the last activity was over 90 days ago.

github-actions[bot] avatar Apr 04 '24 10:04 github-actions[bot]

ping

udf2457 avatar Apr 04 '24 10:04 udf2457

We triage inactive PRs and issues in order to make it easier to find active work. If this issue should remain active or becomes active again, please add a comment.

This issue is labeled inactive because the last activity was over 90 days ago.

github-actions[bot] avatar Jul 05 '24 10:07 github-actions[bot]

$hello_world

udf2457 avatar Jul 05 '24 10:07 udf2457

protobuf is already published to https://registry.bazel.build/modules/protobuf and managed by the protobuf team.

meteorcloudy avatar Jul 05 '24 10:07 meteorcloudy

I'm installing the ProtoBuf lib on my Radxa Rock 3A Debian Bullseye to compile the source code for NCNN. When I executed the command,

bazel build :protoc :protobuf

it raise an error:

INFO: Reading rc options for 'build' from /home/radxa/protobuf-28.1/.bazelrc: Inherited 'common' options: --noenable_bzlmod --repo_env=BAZEL_NO_APPLE_CPP_TOOLCHAIN=1 ERROR: --noenable_bzlmod :: Unrecognized option: --noenable_bzlmod

I checked .bazelrc, and found this link. Any Idea or help pls.

touchinglie avatar Sep 12 '24 17:09 touchinglie

@touchinglie Please upgrade your Bazel version to at least Bazel 6, ideally Bazel 7

meteorcloudy avatar Sep 13 '24 09:09 meteorcloudy

@opicaud @zhangskz I think this can be closed?

alexeagle avatar Dec 06 '24 23:12 alexeagle