protobuf icon indicating copy to clipboard operation
protobuf copied to clipboard

Fix compilation errors in VS due to template declaration

Open feast107 opened this issue 3 years ago • 6 comments

This causes various continuous lines of compilation error within vs.

feast107 avatar Nov 21 '22 14:11 feast107

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Nov 21 '22 14:11 google-cla[bot]

@feast107 Please sign the CLA so we can assign a reviewer to this PR. For more information see: https://github.com/protocolbuffers/protobuf/pull/11034/checks?check_run_id=9617744316

googleberg avatar Nov 23 '22 17:11 googleberg

@feast107 Please sign the CLA so we can assign a reviewer to this PR. For more information see: https://github.com/protocolbuffers/protobuf/pull/11034/checks?check_run_id=9617744316

Thanks for your reminding, I've now signed the CLA.

feast107 avatar Nov 23 '22 18:11 feast107

I would like to know the build situation this time

feast107 avatar Nov 30 '22 08:11 feast107

@feast107 I think you'll need to rebase this PR to get past a testing breakage.

googleberg avatar Nov 30 '22 17:11 googleberg

@feast107 If you rebase this PR I can rerun the tests for you!

deannagarcia avatar Jan 04 '23 21:01 deannagarcia

btw, you will want to rebase on our main branch, there have been a lot of changes in our testing infrastructure in the last few weeks.

haberman avatar Feb 17 '23 19:02 haberman