node_exporter icon indicating copy to clipboard operation
node_exporter copied to clipboard
verified publisher icon prometheus

udp_queues_linux.go: Expose UDP drops via gauge analogous to queue sizes

Open cleeland opened this issue 2 years ago • 9 comments

Since a common reason for monitoring UDP queue sizes can be in teasing out performance and QoS issues, it would be convenient to have drops available in the same frames of data. Since the underlying source of the data provides that information, this PR exposes drops modeled as a gauge just as queue sizes are.

@discordianfish @SuperQ

cleeland avatar Apr 18 '24 20:04 cleeland

@discordianfish @SuperQ I'm assuming that the failing circleci tests are because I need to update the fixtures (via make update_fixtures)? I'm having problems doing that running natively on macos. Is updating fixtures something that only reliably works on linux? If so, I'll make that happen in docker or a VM.

cleeland avatar Apr 19 '24 20:04 cleeland

I'm not sure why test_docker is failing, and I can't pull the base image to run the test manually. It complains that I am unauthorized. From what I can tell, quay.io does not have a no-cost tier.

cleeland avatar Apr 22 '24 17:04 cleeland

Wait, no, this seems incorrect. Drops appears to be a counter, so this needs to be a new metric, not a label on an existing metric.

Drat; you're right. Let me see if I can fix this quickly.

cleeland avatar Apr 22 '24 20:04 cleeland