Request to add label for mount point to mountstats

[jgauth]

Currently the labels for NFS metrics from mountstats are "export", "protocol", "mountaddr"

I'm requesting that another label be added, the mountpoint on the NFS client.

For example if /proc/self/mountstats had the following device info: device myhostname.com:/exports/example mounted on /auto/example with fstype nfs statvers=1.1

I'd like to have a label: mountpoint: /auto/example, in addition to the label export: myhostname.com:/exports/example

It looks like this is already supported by procfs: https://github.com/prometheus/procfs/blob/master/mountstats.go#L314

[discordianfish]

Yeah agree, this should have a mountpoint label.

[SuperQ]

Did we have something like this previously, but removed it to avoid duplicate metrics?

[jgauth]

Looks like it: https://github.com/prometheus/node_exporter/commit/5a6db5c8d22f9a73473014f42cfc5bc18053666d#

Can we include the mountpoint label, while also skipping duplicates?

[SuperQ]

Yea, that seems reasonable. Pick first one, ignore the rest, is that good enough?

[conallob]

I would like to work on this, unless there is already someone actively working on it

[jgauth]

@conallob Please feel free to pick up where I left off - https://github.com/prometheus/node_exporter/pull/2102

[dsnt02518]

By bizarre synchronicity I was actually working on a patch for this before I was aware of this issue. Hopefully the PR above will either resolve this or at least prove helpful.

[conallob]

I'll take a look at #2102 and try to get a PR out this week

[conallob]

@dsnt02518 Since you have https://github.com/prometheus/node_exporter/pull/2676 already open, I'll leave this to you