add color logging capabilities for promlog

Open cstyan opened this issue 8 years ago • 5 comments

Add's color logging capabilities to promlog when we're logging to the terminal, otherwise we just get a standard go-kit logger when logging to a file. We'll have to update deps/vendor packages in prometheus after we merge.

cc: @krasi-georgiev @juliusv

Dec 22 '17 19:12 cstyan

cc: @fabxc

Dec 27 '17 22:12 cstyan

Did you check if colours can be applied to selected name=value groups rather than the entire line?

Dec 27 '17 23:12 krasi-georgiev

AFAICT, that would require a change to the go-kit/log/term package. So unless anyone thinks it's really necessary, I'll just leave the colors change as is for now.

Dec 28 '17 00:12 cstyan

Is this still wanted?

Jan 20 '20 12:01 brian-brazil

This PR seems fine, but it needs a rebase for the change to go-kit/log

Feb 25 '23 10:02 SuperQ