client_python icon indicating copy to clipboard operation
client_python copied to clipboard

Add deadlock prevention during metric registration

Open suligap opened this issue 1 year ago • 2 comments

Detect deadlocks during the library misuse, eg. by injecting code into the critical sections that itself might want to obtain the relevant lock.

A follow up to #1076.

suligap avatar Dec 03 '24 20:12 suligap

Just want to say I have been busy this week and am out next week, but I will get to this, and thank you for your contributions!

csmarchbanks avatar Dec 06 '24 15:12 csmarchbanks

No worries, nothing urgent here and thanks. I thought about it a bit more and ended up pulling out the deadlock prevention from the "hottest" path: metrics.py and values.py. It's quite hard to justify the overhead of this double locking approach there. But I think it's not an issue in registry.py.

suligap avatar Dec 08 '24 15:12 suligap