client_golang icon indicating copy to clipboard operation
client_golang copied to clipboard

replace github.com/golang/protobuf with google protobuf

Open ahrycej opened this issue 2 years ago • 5 comments

Replace the github.com/golang/protobuf-1.5.3 with google code

The whole project seem to be depricated and it is recommended to go for google from https://github.com/golang/protobuf

"It has been superseded by the google.golang.org/protobuf module, which contains an updated and simplified API, support for protobuf reflection, and many other improvements. We recommend that new code use the google.golang.org/protobuf module.

Versions v1.4 and later of github.com/golang/protobuf are implemented in terms of google.golang.org/protobuf. Programs which use both modules must use at least version v1.4 of this one."

ahrycej avatar May 23 '23 11:05 ahrycej

To solve this problem, you need to start from github.com/prometheus/common, the ultimate reason is that github.com/prometheus/common depends on github.com/matttproud/golang_protobuf_extensions (very old and out of date).

edoger avatar Jun 05 '23 02:06 edoger

Linking issue: https://github.com/prometheus/common/issues/317

rufreakde avatar Sep 07 '23 10:09 rufreakde

+1

pavelpatrin avatar Oct 06 '23 08:10 pavelpatrin

this is fixed now, right?

clambin avatar Jan 20 '25 14:01 clambin

this is fixed now, right?现在已经解决了,对吧?

After verification, it has indeed been solved!

edoger avatar Jan 20 '25 15:01 edoger