blackbox_exporter icon indicating copy to clipboard operation
blackbox_exporter copied to clipboard

Add `fail_if_body_too_large` http probe option

Open hashworks opened this issue 1 year ago • 9 comments

This can be used in conjunction with body_size_limit when it is expected that endpoints return a body larger than the specified limit, e.g. streaming endpoints that potentially return infinite data.

hashworks avatar Aug 06 '24 09:08 hashworks

Do you want any changes here? Or is this a feature you don't want merged?

hashworks avatar Nov 01 '24 13:11 hashworks

can you share more on the use-case? and what problem this flag will solve?

once I better understand the "why?" behind the change, I will find some time to review.

electron0zero avatar Dec 31 '24 08:12 electron0zero

can you share more on the use-case? and what problem this flag will solve?

At work, we need to probe endpoints that endlessly stream data. Without this flag every probe will fail after some time, since Blackbox Exporter expects the data stream to finish otherwise. We want to measure successful requests and "time to X bytes".

hashworks avatar Dec 31 '24 09:12 hashworks

please rebase to fix the failing CI.

electron0zero avatar Dec 31 '24 10:12 electron0zero

Sorry for the delay, added the requested changes.

hashworks avatar Feb 09 '25 15:02 hashworks

Fixed the DCO CI failures.

hashworks avatar Feb 12 '25 21:02 hashworks

I don't think the test failures are related to my changes. Are they green on master?

hashworks avatar Feb 12 '25 21:02 hashworks

Are they green on master?

yes, try rebasing on the latest main.

electron0zero avatar Feb 13 '25 11:02 electron0zero

Hm... the branch is up2date.

hashworks avatar Feb 13 '25 12:02 hashworks